Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite section in documentation about on source include/excludes #1682

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Rewrite section in documentation about on source include/excludes #1682

merged 1 commit into from
Sep 9, 2023

Conversation

Julian-O
Copy link
Contributor

@Julian-O Julian-O commented Sep 8, 2023

The section in the documentation on source.includes/excludes is:

  • Incomplete. It doesn't mention include_patterns or "hidden" files.
  • Wrong: It says "If [source.exclude_exts is]
    empty, no files will be excluded based on their extensions." Reading the code reveals that if source.exclude_exts is empty, it has no effect.
  • Unclear: Little mention on how the different options interact.

This is a re-write to attempt to fix that.

misl6
misl6 approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@misl6 misl6 merged commit d59cc0d into kivy:master Sep 9, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misl6 misl6 misl6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Julian-O @misl6